Added the ability to inject redis clients into the Faye Redis engine. #13
Conversation
|
👍 This looks like it would work for the myriad of sentinel clients that exist (personally, I picked https://github.com/flyerhzm/redis-sentinel) and would also allow for simpler testing with https://github.com/hdachev/fakeredis as well |
|
bump? |
|
@evantahler Please don't do that, it's passive-aggressive. I have been having a really rough year and am trying to catch up on my OSS stuff. I'm getting to everything as soon as I can. |
|
@jcoglan, sorry about the broken build on this PR. I've got no idea why redis seems to be failing on the travis build when running against Node 0.6. All the other builds (node 0.8, etc) pass. Any ideas? |
|
For the record, 0.6 is no longer part of the Travis build, so it should pass the build checks now. |
|
IMO option Also note:
@jcoglan what is status of this pakage? Can i help with refresh of outdated codebase? Or i should do the fork? |
|
@puzrin I am not sure why you even bother asking. This package has not seen a single maintenance commit in seven years. James should have just archived the repo. |
|
@fatso83 it's not difficult to ask an be polite, before switch to gitterhq fork :) |
|
@puzrin The GitterHQ has not seen any action in years either, so if you encounter any other issues, I would frankly look for an alternative. Still, if it works and scratches your itch, old software is good software :) |
This PR allows the Redis client to be injected into the Faye Redis engine, instead of having it instantiated by the engine itself (using the
host,portetc options).Background
We're currently moving across to using Redis Sentinel. In node, we're using Node Redis Sentinel Client to coordinate our Redis connections. This library provides a client which walks like a Redis client and talks like a Redis client, but isn't a standard Redis client (as it maintains a connection to the Sentinel, listening for failover messages, etc).
Implementation
Two extra options have been added to the Faye Redis engine:
clientandsubscriberClient. These are intended to be used together and as an alternative to specifying the Redis connection parametershost,portetc. They should each reference a Redis client (or in our case a Redis-client-like object).